apps/modbus: Move modbus to inside industry/#3457
Conversation
Modbus is a protocol mostly used on industries and since it is a protocol it is not a category to be at root of apps/ Signed-off-by: Alan C. Assis <acassis@gmail.com>
|
|
|
Hi @acassis, you also need to remove add_subdirectory(modbus) from the CMake file |
I decided to keep the original name as @raiden00pl moved it from modbus to freemodbus. Please note that many MB_* also were kept. |
Thank you, I missed that |
Modbus is a protocol mostly used on industries and since it is a protocol it is not a category to be at root of apps/ Signed-off-by: Alan C. Assis <acassis@gmail.com>
|
the job Linux (xtensa-01) fails here because use Apache nuttx master as a reference Since the Apache nuttx master doesn't contain the additional changes required, it rightly fails I tested it here https://github.com/simbit18/manual-nuttx-ci/actions/runs/24637035652 using this new apache/nuttx#18568 tool and didn’t encounter any issues Set it up as follows: Workflow -> Manually build NuttX CI for test I'm merging this PR |
Summary
Modbus is a protocol mostly used on industries and since it is a protocol it is not a category to be at root of apps/
Impact
None, only organization
Testing
On NuttX board:
On Linux side: