Skip to content

arch/sim: Fix NXWM test failure#456

Merged
btashton merged 1 commit into
apache:masterfrom
sebastianene07:sene/arch_sim_fix_nxwm_test_failure
Nov 1, 2020
Merged

arch/sim: Fix NXWM test failure#456
btashton merged 1 commit into
apache:masterfrom
sebastianene07:sene/arch_sim_fix_nxwm_test_failure

Conversation

@sebastianene07

@sebastianene07 sebastianene07 commented Oct 31, 2020

Copy link
Copy Markdown

Summary of changes

Fixed the crash caused by a NULL memory access to an invalid background
window fixes.

Testing

Verified that the simulation is starting without a crash. An image is displayed in the simulation window.

Signed-off-by: Sebastian Ene sene@apache.org

Comment thread graphics/nxwm/src/ctaskbar.cxx Outdated
Comment thread graphics/nxwm/src/ctaskbar.cxx Outdated
@Ouss4

Ouss4 commented Nov 1, 2020

Copy link
Copy Markdown
Member

@xiaoxiang781216 please, label this one if it needs to be backported.
I also asked if the kernal PR needs to be backported too.

 ## Summary of changes

Fixed the crash caused by a NULL memory access to an invalid background
window.

Signed-off-by: Sebastian Ene <sene@apache.org>
@sebastianene07 sebastianene07 force-pushed the sene/arch_sim_fix_nxwm_test_failure branch from a898ffe to 5e2979a Compare November 1, 2020 16:16
@btashton btashton merged commit fce08ec into apache:master Nov 1, 2020
@xiaoxiang781216

Copy link
Copy Markdown
Contributor

@btashton need to fix apache/nuttx#2093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants