Docker: Build the needed binaries from esp-idf#20
Merged
Conversation
Contributor
Author
|
@liuguo09 if you could take a look when you get a chance that would be great. |
This was referenced Mar 23, 2020
liuguo09
reviewed
Mar 23, 2020
| @@ -0,0 +1 @@ | |||
| /xtensa | |||
Contributor
There was a problem hiding this comment.
Let's move /xtensa into mips-riscv-x86.dat to save one job build in github action CI.
Contributor
Author
There was a problem hiding this comment.
I have created a copy of it as mips-riscv-v86-xtensa.dat but I did not delete the old mips-riscv-x86.dat file because doing so would break the current CI builds. One this is all updated we can removed the unused one.
Contributor
There was a problem hiding this comment.
Yes, let's remove it later.
Contributor
|
Maybe esp-idf binaries should also come into cibuild.sh -i setup tools. |
xiaoxiang781216
approved these changes
Mar 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bootloader and partition-table blobs are now built as part of the CI image and placed here
/tools/blobs/esp32core/The thought is any other binary blobs that we might need for other testing can also be placed here, for example the Broadcom WIFI firmware.There is an example CI run using this here showing everything passing include the xtensa builds: https://github.com/btashton/incubator-nuttx/runs/526365535?check_suite_focus=true