chardriver upperCAN: support to independent set TX/RX FIFO size.#13762
Merged
Conversation
|
[Experimental Bot, please feedback here] This PR summary is too short and lacks the necessary details for a proper review. Here's a breakdown of what's missing and how to improve it: Summary
Impact You need to address each point in the impact section:
Testing
In short, you need to expand each section of your PR with specific details about your changes to make it easier for reviewers to understand and approve. |
xiaoxiang781216
approved these changes
Sep 30, 2024
acassis
approved these changes
Sep 30, 2024
pkarashchenko
left a comment
Contributor
There was a problem hiding this comment.
All is good except point highlighted by Alan
pkarashchenko
approved these changes
Sep 30, 2024
support to independent set TX/RX FIFO size. Signed-off-by: zhaohaiyang1 <zhaohaiyang1@xiaomi.com>
bc33f71 to
f57c9eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support to independent set TX/RX FIFO size
Impact
Testing