task: use get_task_name where possible#13771
Merged
Merged
Conversation
|
[Experimental Bot, please feedback here] This PR appears incomplete based on the NuttX requirements. Here's why and what's missing:
In short: Don't assume reviewers understand the context. Provide enough detail to make the PR's value and correctness immediately clear. |
anchao
requested changes
Oct 1, 2024
Signed-off-by: xuxingliang <xuxingliang@xiaomi.com>
f26c708 to
fc1614c
Compare
xiaoxiang781216
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
get_task_nameto streamline code by replacing (#if #else #endif) with a cleaner implementation.Impact
For debug log, instead of printing nothing, now it will print "noname".
Testing
CI test should be enough for this change.