modlib:#13819
Merged
Merged
Conversation
1. use '__attribute__((constructor))' mark initialize function
2. use '__attribute__((destructor))' mark uninitialize function
3. compile module with -fvisibility=hidden. use `__attribute__((visibility("default")))`
mark is need export symbol.so not need module_initialize to initialize export symbol.
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
Signed-off-by: anjiahao <anjiahao@xiaomi.com>
|
[Experimental Bot, please feedback here] The PR summary is insufficient and lacks detail. Here's a breakdown of what's missing and how to improve it: Summary Issues:
Impact Issues:
Testing Issues:
To make this PR meet NuttX requirements, you need to:
|
cederom
reviewed
Oct 4, 2024
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @anjiahao1 :-)
- Are there any possible compiler / linker compatibility issues?
- Do we need to update documentation as well?
xiaoxiang781216
approved these changes
Oct 5, 2024
Contributor
The new approach uses the same mechanism of C++ constructor and destructor, so it's more general than before. Actually, so with the global c++ object work now with this change.
No documentation reference mod_initializer_t |
xiaoxiang781216
approved these changes
Oct 5, 2024
Contributor
|
Hi @anjiahao1 , this PR also broke Any idea? |
Contributor
Hi @anjiahao1 , were you able to verify anything further? |
This was referenced Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The loading method of modlib has been optimized to allow dynamic modules to be loaded using attribute((destructor)), eliminating the need for module_initialize.
Impact
modlib
Testing
qemu with mps3 an547