Skip to content

net: Remove IFF_DOWN flag to compatible with Linux/*BSD #13842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GUIDINGLI merged 1 commit into from
Oct 8, 2024
Merged

net: Remove IFF_DOWN flag to compatible with Linux/*BSD #13842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boards/arm/s32k3xx/mr-canhubk3/src/s32k3xx_tja1153.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ int s32k3xx_tja1153_initialize(int bus)

/* Bring down the interface */

ifr.ifr_flags = IFF_DOWN;
ifr.ifr_flags = 0;
ret = ioctl(sock, SIOCSIFFLAGS, (unsigned long)&ifr);
if (ret < 0)
{
Expand Down
3 changes: 1 addition & 2 deletions drivers/wireless/ieee80211/bcm43xxx/bcmf_netdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,8 +921,7 @@ static int bcmf_ioctl(FAR struct net_driver_s *dev, int cmd,

if (!priv->bc_bifup)
{
wlerr("ERROR: invalid state "
"(IFF_DOWN, unable to execute command: %x)\n", cmd);
wlerr("ERROR: invalid state (unable to execute command: %x)\n", cmd);
return -EPERM;
}

Expand Down
1 change: 0 additions & 1 deletion include/net/if.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@

/* Interface flag bits */

#define IFF_DOWN (1 << 0) /* Interface is down */
#define IFF_UP (1 << 1) /* Interface is up */
#define IFF_RUNNING (1 << 2) /* Carrier is available */
#define IFF_IPv6 (1 << 3) /* Configured for IPv6 packet (vs ARP or IPv4) */
Expand Down
5 changes: 1 addition & 4 deletions net/netdev/netdev_ioctl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,10 +990,7 @@ static int netdev_ifr_ioctl(FAR struct socket *psock, int cmd,
arp_acd_setup(dev);
#endif /* CONFIG_NET_ARP_ACD */
}

/* Is this a request to take the interface down? */

else if ((req->ifr_flags & IFF_DOWN) != 0)
else
{
/* Yes.. take the interface down */

Expand Down