Skip to content

CI: Check out the correct branch of nuttx repo when compiling nuttx-apps#14518

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
lupyuen2:osref
Nov 4, 2024
Merged

CI: Check out the correct branch of nuttx repo when compiling nuttx-apps#14518
xiaoxiang781216 merged 1 commit into
apache:masterfrom
lupyuen2:osref

Conversation

@lupyuen

@lupyuen lupyuen commented Oct 27, 2024

Copy link
Copy Markdown
Member

Summary

When compiling the Release Branch of nuttx-apps, our CI Workflow build.yml checks out the Master Branch of nuttx repo, which is incorrect. This happens due to a typo in build.yml: #14513

This PR fixes the typo in build.yml to checkout the correct branch of nuttx repo.

Impact

When compiling the Release Branch of nuttx-apps, our CI Workflow build.yml now checks out the Release Branch of nuttx repo.

No changes when compiling the Master Branch of nuttx and nuttx-apps repos.

Testing

Before the PR: Fetch-Source Log shows that CI is incorrectly checking out the Master Branch of nuttx repo (instead of releases/12.7): https://github.com/apache/nuttx-apps/actions/runs/11518661640/job/32069568370#step:3:66

/usr/bin/git checkout --progress --force -B master refs/remotes/origin/master

After the PR: When we change name to os_ref, CI correctly checks out the Release Branch of nuttx repo: https://github.com/lupyuen5/label-nuttx-apps/actions/runs/11528123257/job/32094821811#step:3:57

/usr/bin/git checkout --progress --force -B releases/12.7 refs/remotes/origin/releases/12.7

Regression Test:

@github-actions github-actions Bot added Area: CI Size: XS The size of the change in this PR is very small labels Oct 27, 2024

@cederom cederom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen :-) Go ahead when ready :-)

When compiling the Release Branch of `nuttx-apps`, our CI Workflow `build.yml` checks out the Master Branch of `nuttx` repo, which is incorrect. This happens due to a typo in `build.yml`: apache#14513

This PR fixes the typo in `build.yml` to checkout the correct branch of `nuttx` repo.
@lupyuen lupyuen marked this pull request as ready for review November 4, 2024 02:35
@lupyuen lupyuen marked this pull request as draft November 4, 2024 02:35
@lupyuen lupyuen marked this pull request as ready for review November 4, 2024 04:14
@xiaoxiang781216 xiaoxiang781216 merged commit 38fbb4e into apache:master Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Size: XS The size of the change in this PR is very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] When building nuttx-apps, CI Workflow checks out the Incorrect Branch of nuttx repo

4 participants