riscv: Some judgments are missing#15030
Merged
Merged
Conversation
Merged
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and identifies the impacted architecture, it lacks crucial information. Here's what's missing:
The PR needs to be expanded to address these missing points before it can be considered complete. |
lupyuen
approved these changes
Dec 3, 2024
lupyuen
left a comment
Member
There was a problem hiding this comment.
Tested OK with OSTest on rv-virt:knsh, rv-virt:knsh64 and rv-virt:nsh64. Thanks! :-)
xiaoxiang781216
approved these changes
Dec 3, 2024
9187345 to
7a2a52a
Compare
acassis
approved these changes
Dec 3, 2024
pussuw
reviewed
Dec 3, 2024
00acae1 to
cb4e3c2
Compare
pussuw
approved these changes
Dec 4, 2024
This commit fixes the regression from apache#14984 Signed-off-by: hujun5 <hujun5@xiaomi.com>
xiaoxiang781216
approved these changes
Dec 4, 2024
jerpelea
approved these changes
Dec 4, 2024
xiaoxiang781216
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the regression from #14984
Impact
riscv
Testing
ostest rv-virt:knsh