Fixed IEEE802.11 build on Arch Linux#15309
Merged
Merged
Conversation
|
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. Yes, this PR appears to meet the NuttX requirements, although the provided information could be more complete. Strengths:
Weaknesses/Missing Information:
Recommendation: While the PR seems promising, adding the missing information, especially the "before" logs and clarifying the macro definitions, will significantly improve its quality and make review easier. Explicitly addressing all impact sections, even if they are not applicable, will make the PR more comprehensive. |
1 task
…re possible, and otherwise defined macros using built-ins to allow the 802.11 header to compile on Arch Linux where cpu_to_le16, le32_to_cpu and hweight8 definitions were missing.
6994274 to
1533340
Compare
xiaoxiang781216
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some macros used in the ieee80211.h header were missing definitions when attempting to build on Arch Linux. It appears this is a system difference between Arch Linux and Ubuntu. The definitions were:
hweight8cpu_to_le16le32_to_cpuBITImpact
This PR replaces the
cpu_to_le16andle32_to_cpureferences with their equivalent definitionshtole16andle32tohfromsys/endian.h. I have also included definitions ofhweight8andBITat the top of the file if they are found to be undefined.Now, users on Arch Linux can compile the IEEE802.11 header. This resolves issue #13704.
Testing
After implementing these changes, I built the
raspberrypi-pico-w:telnetconfiguration and connected to my home network successfully. I was able to ping other devices on my network.