add LINE_MAX and modify lib_pathbuffer#15344
Merged
Merged
Conversation
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
…CONFIG_LINE_MAX Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
anchao
approved these changes
Dec 26, 2024
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements as described. Here's why:
In short, the PR description needs to be much more thorough and specific to meet the NuttX requirements. Provide concrete details and evidence to support your claims. |
JianyuWang0623
added a commit
to JianyuWang0623/nuttx-apps
that referenced
this pull request
Jan 14, 2025
LINE_MAX: apache/nuttx#15344 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
xiaoxiang781216
pushed a commit
to apache/nuttx-apps
that referenced
this pull request
Jan 14, 2025
LINE_MAX: apache/nuttx#15344 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
xiaoxiang781216
pushed a commit
to open-vela/nuttx-apps
that referenced
this pull request
Jan 16, 2025
LINE_MAX: apache/nuttx#15344 Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add LINE_MAX and modify lib_pathbuffer
Due to the continuous expansion of functions under the app, the 2k stack of many programs can no longer meet the requirements. If malloc is used frequently, memory fragmentation may occur, and we need an interface to optimize the use of stack and avoid memory fragmentation.
There are many similar configurations in the code:
config SYSTEM_CLE_CMD_HISTORY_LEN
config SYSTEM_CLE_CMD_HISTORY_LINELEN
CONFIG_NSH_LINELEN
HELP_LINELEN
PROCFS_LINELEN
The future plan is to remove these configurations and use LINE_MAX
Impact
Optimize the use of stacks
Testing
local test