goldfish_sensor_uorb.c: add set_interval for goldfish sensor#15412
Merged
Conversation
Added the ability to set sampling rate for goldfish Signed-off-by: chenzihan1 <chenzihan1@xiaomi.com>
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements as described. While it provides a summary and mentions testing, it lacks crucial details. Here's a breakdown of what's missing:
In short, the PR needs significantly more detail to meet the NuttX requirements. It needs to be more explicit and demonstrate a thorough understanding of the change's impact and provide evidence of proper testing. |
acassis
approved these changes
Jan 3, 2025
Donny9
approved these changes
Jan 3, 2025
xiaoxiang781216
approved these changes
Jan 8, 2025
Contributor
|
let's ignore ci error fixed by: apache/nuttx-apps#2925 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the ability to set sampling rate for goldfish
Impact
Now goldfish sensor can adjust the sampling rate
Testing
qemu uorb_listener