Skip to content

rp23xx_irq.c: fix regression from https://github.com/apache/nuttx/pull/15073#15505

Closed
hujun260 wants to merge 1 commit into
apache:masterfrom
hujun260:apache_mastar
Closed

rp23xx_irq.c: fix regression from https://github.com/apache/nuttx/pull/15073#15505
hujun260 wants to merge 1 commit into
apache:masterfrom
hujun260:apache_mastar

Conversation

@hujun260

Copy link
Copy Markdown
Contributor

Summary

fix regression from #15073

Impact

arch/arm/src/rp23xx/rp23xx_irq.c

Testing

ci #15503

Signed-off-by: hujun5 <hujun5@xiaomi.com>
@github-actions github-actions Bot added Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small labels Jan 13, 2025
@nuttxpr

nuttxpr commented Jan 13, 2025

Copy link
Copy Markdown

[Experimental Bot, please feedback here]

No. This PR description lacks crucial information required by the NuttX guidelines.

Here's what's missing:

  • Summary: While it links a prior PR, it doesn't explain what the regression is. What functionality was broken? How does this PR fix it? What part of the code was changed and how?
  • Impact: The current entry just lists a file path. It needs to explicitly answer all the impact questions (user impact, build impact, hardware impact, documentation, security, compatibility). Use "NO" or "YES" followed by a description if yes.
  • Testing: Linking to a CI issue isn't sufficient. It needs to specify the local test setup used (host OS, compiler, target architecture and board) and provide actual before/after testing logs demonstrating the fix. Simply pointing to a CI run doesn't show what specific tests were run locally and their results.

The author needs to substantially expand this PR description to be accepted.

@hujun260 hujun260 closed this Jan 13, 2025
@hujun260 hujun260 deleted the apache_mastar branch January 24, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants