drivers/segger/CMakeLists.txt: Aligned Cmake with Make#16620
Merged
Conversation
Segger SysView has been upgraded to version V3.5.6 apache#13847 Signed-off-by: simbit18 <simbit18@gmail.com>
github-actions
Bot
added
Area: Drivers
xiaoxiang781216
approved these changes
Jun 25, 2025
Contributor
|
it's better to change the hard code value to Kconfig, let's boths file reference the same symbol to avoid the divergence in the future. |
Contributor
Author
|
Hi @xiaoxiang781216 yes, it would be preferable. |
acassis
approved these changes
Jun 25, 2025
Contributor
|
@simbit18 do you prefer we merge this fix and you add the Kconfig feature later? Or do you want to close it now? |
Contributor
Author
|
@acassis better to merge this PR first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Segger SysView has been upgraded to version V3.5.6
PR #13847
Impact
Impact on user: NO
Impact on build: NO
Impact on hardware: NO
Impact on documentation: NO
Impact on security: NO
Impact on compatibility: NO
Testing
CI