Skip to content

Example of use of tools/Jenkinsfile#174

Closed
maht wants to merge 1 commit into
apache:masterfrom
maht:master
Closed

Example of use of tools/Jenkinsfile#174
maht wants to merge 1 commit into
apache:masterfrom
maht:master

Conversation

@maht

@maht maht commented Jan 28, 2020

Copy link
Copy Markdown

Companion pull request for the one at this pull request to illustrate relation of the two repositories. See description there.

Not intended to be merged right now.

@xiaoxiang781216

Copy link
Copy Markdown
Contributor

@liuguo09 please take a look.

Comment thread tools/Jenkinsfile
@@ -0,0 +1,11 @@
#!/usr/bin/env groovy

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a license header required? I think yes.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I added it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maht do we still need this patch, if we you github action to do precheck:
#261

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiaoxiang781216 No, we don't need it anymore. It can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants