Skip to content

mm: handle take mm sem in IRQ #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acassis merged 1 commit into from
Feb 16, 2022
Merged

mm: handle take mm sem in IRQ #5504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mm/mm_heap/mm_foreach.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ void mm_foreach(FAR struct mm_heap_s *heap, mmchunk_handler_t handler,
* Retake the semaphore for each region to reduce latencies
*/

DEBUGVERIFY(mm_takesemaphore(heap));
if (!mm_takesemaphore(heap))
{
return;
}

for (node = heap->mm_heapstart[region];
node < heap->mm_heapend[region];
Expand Down
25 changes: 23 additions & 2 deletions mm/mm_heap/mm_sem.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,23 @@ bool mm_takesemaphore(FAR struct mm_heap_s *heap)
#if defined(CONFIG_BUILD_FLAT) || defined(__KERNEL__)
else if (sched_idletask())
{
/* Try to take the semaphore */
return false;
}
else if (up_interrupt_context())
{
#ifdef CONFIG_SMP
return false;
#else
int val;

return _SEM_TRYWAIT(&heap->mm_semaphore) >= 0;
/* Check the semaphore value, if held by someone, then return false.
* Else, we can take it, return true.
*/

_SEM_GETVALUE(&heap->mm_semaphore, &val);

return val > 0;
#endif
}
#endif
else
Expand Down Expand Up @@ -145,5 +159,12 @@ bool mm_takesemaphore(FAR struct mm_heap_s *heap)

void mm_givesemaphore(FAR struct mm_heap_s *heap)
{
#if defined(CONFIG_BUILD_FLAT) || defined(__KERNEL__)
if (up_interrupt_context())
{
return;
}
#endif

DEBUGVERIFY(_SEM_POST(&heap->mm_semaphore));
}