Skip to content

dump_task: also dump thread param when dump thread name#6367

Merged
pkarashchenko merged 5 commits into
apache:masterfrom
xiaoxiang781216:assert
Jun 7, 2022
Merged

dump_task: also dump thread param when dump thread name#6367
pkarashchenko merged 5 commits into
apache:masterfrom
xiaoxiang781216:assert

Conversation

@xiaoxiang781216

@xiaoxiang781216 xiaoxiang781216 commented Jun 5, 2022

Copy link
Copy Markdown
Contributor

Summary

and make the column order same as ps output. Found in #6337

Impact

up_assert output

Testing

GUIDINGLI and others added 3 commits June 5, 2022 17:51
Signed-off-by: ligd <liguiding1@xiaomi.com>
to avoid error: "invalid use of undefined type 'struct task_info_s'

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Comment thread arch/arm/src/common/arm_assert.c Outdated
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Comment thread arch/risc-v/src/common/riscv_assert.c Outdated
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>

@pkarashchenko pkarashchenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xiaoxiang781216

Copy link
Copy Markdown
Contributor Author

BTW, since tcb->group->tg_info->argv[0] always point to the task name, I plan to create a new patch in the future:

  1. Change tcb->name to FAR const char * and point to tcb->group->tg_info->argv[0] in flat and protected build
  2. Keep tcb->name as the char array in kernel build as before, but prohibit to set CONFIG_TASK_NAME_SIZE=0

@pkarashchenko pkarashchenko merged commit 28b25e0 into apache:master Jun 7, 2022
@xiaoxiang781216 xiaoxiang781216 deleted the assert branch June 7, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants