-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Added memory health checks. #6631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fjpanag
wants to merge
1
commit into
apache:master
Choose a base branch
from
fjpanag:health_check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+168
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| ############################################################################ | ||
| # mm/mm_check/Make.defs | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. The | ||
| # ASF licenses this file to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance with the | ||
| # License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| ############################################################################ | ||
|
|
||
| # Memory health checks. | ||
|
|
||
| ifeq ($(CONFIG_MM_HEALTH_CHECK),y) | ||
| CSRCS += mm_check.c | ||
|
|
||
| # Add the health checks to the build. | ||
|
|
||
| DEPPATH += --dep-path mm_check | ||
| VPATH += :mm_check | ||
| endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,94 @@ | ||||||
| /**************************************************************************** | ||||||
| * mm/mm_check/mm_check.c | ||||||
| * | ||||||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||||||
| * contributor license agreements. See the NOTICE file distributed with | ||||||
| * this work for additional information regarding copyright ownership. The | ||||||
| * ASF licenses this file to you under the Apache License, Version 2.0 (the | ||||||
| * "License"); you may not use this file except in compliance with the | ||||||
| * License. You may obtain a copy of the License at | ||||||
| * | ||||||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||||||
| * | ||||||
| * Unless required by applicable law or agreed to in writing, software | ||||||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||||||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||||||
| * License for the specific language governing permissions and limitations | ||||||
| * under the License. | ||||||
| * | ||||||
| ****************************************************************************/ | ||||||
|
|
||||||
| /**************************************************************************** | ||||||
| * Included Files | ||||||
| ****************************************************************************/ | ||||||
|
|
||||||
| #include <nuttx/mm/mm.h> | ||||||
| #include <nuttx/sched.h> | ||||||
| #include <nuttx/irq.h> | ||||||
| #include <nuttx/wqueue.h> | ||||||
| #include <nuttx/arch.h> | ||||||
| #include <nuttx/compiler.h> | ||||||
| #include <nuttx/config.h> | ||||||
|
|
||||||
| #include <time.h> | ||||||
| #include <assert.h> | ||||||
| #include <sys/types.h> | ||||||
|
|
||||||
| /**************************************************************************** | ||||||
| * Pre-processor Definitions | ||||||
| ****************************************************************************/ | ||||||
|
|
||||||
| #ifndef CONFIG_SCHED_LPWORK | ||||||
| #error "Low priority work queue is required for the memory health checks." | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| #endif | ||||||
|
|
||||||
| /**************************************************************************** | ||||||
| * Private Types | ||||||
| ****************************************************************************/ | ||||||
|
|
||||||
| static struct work_s work_q; | ||||||
|
|
||||||
| /**************************************************************************** | ||||||
| * Private Functions | ||||||
| ****************************************************************************/ | ||||||
|
|
||||||
| static void mm_check_worker(FAR void * arg) | ||||||
| { | ||||||
| UNUSED(arg); | ||||||
|
|
||||||
| int i; | ||||||
| FAR struct tcb_s *tcb; | ||||||
| irqstate_t flags; | ||||||
| extern FAR struct tcb_s **g_pidhash; | ||||||
| extern volatile int g_npidhash; | ||||||
|
|
||||||
| for (i = 0; i < g_npidhash; i++) | ||||||
| { | ||||||
| flags = enter_critical_section(); | ||||||
|
|
||||||
| tcb = g_pidhash[i]; | ||||||
|
|
||||||
| if (tcb && ((up_check_tcbstack(tcb) * 100 / tcb->adj_stack_size) | ||||||
| > CONFIG_MM_STACK_USAGE_SAFE_PERCENT)) | ||||||
| { | ||||||
| PANIC(); | ||||||
| } | ||||||
|
|
||||||
| leave_critical_section(flags); | ||||||
| } | ||||||
|
|
||||||
| kmm_checkcorruption(); | ||||||
|
|
||||||
| work_queue(LPWORK, &work_q, mm_check_worker, NULL, | ||||||
| (CONFIG_MM_CHECK_PERIOD * CLOCKS_PER_SEC)); | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| } | ||||||
|
|
||||||
| /**************************************************************************** | ||||||
| * Public Functions | ||||||
| ****************************************************************************/ | ||||||
|
|
||||||
| void mm_check_init() | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| { | ||||||
| work_queue(LPWORK, &work_q, mm_check_worker, NULL, | ||||||
| (CONFIG_MM_CHECK_PERIOD * CLOCKS_PER_SEC)); | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this a first include