Skip to content

Fix vfs/fs_timerfd.c:73:17: error: duplicate member 'lock'#7395

Merged
xiaoxiang781216 merged 2 commits into
apache:masterfrom
xiaoxiang781216:error
Oct 23, 2022
Merged

Fix vfs/fs_timerfd.c:73:17: error: duplicate member 'lock'#7395
xiaoxiang781216 merged 2 commits into
apache:masterfrom
xiaoxiang781216:error

Conversation

@xiaoxiang781216

@xiaoxiang781216 xiaoxiang781216 commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

Summary

regression by: #6965

Impact

Fix compiler error

Testing

Pass CI

@pkarashchenko

Copy link
Copy Markdown
Contributor
Error: proxies/PROXY_socketpair.c:9:55: error: argument 4 of type 'int *' declared as a pointer [-Werror=array-parameter=]
    9 | int socketpair(int parm1, int parm2, int parm3, int * parm4)
      |                                                 ~~~~~~^~~~~
In file included from proxies/PROXY_socketpair.c:4:
/github/workspace/sources/nuttx/include/sys/socket.h:373:56: note: previously declared as an array 'int[2]'
  373 | int socketpair(int domain, int type, int protocol, int sv[2]);

@xiaoxiang781216 it seems like this issues started to appear after we switched to a new toolchain. Seems like CI is fully blocked now

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
… 'int *' declared as a pointer [-Werror=array-parameter=]

    9 | int socketpair(int parm1, int parm2, int parm3, int * parm4)
      |                                                 ~~~~~~^~~~~
In file included from proxies/PROXY_socketpair.c:4:
/github/workspace/sources/nuttx/include/sys/socket.h:373:56: note: previously declared as an array 'int[2]'
  373 | int socketpair(int domain, int type, int protocol, int sv[2]);
      |

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216

xiaoxiang781216 commented Oct 23, 2022

Copy link
Copy Markdown
Contributor Author
Error: proxies/PROXY_socketpair.c:9:55: error: argument 4 of type 'int *' declared as a pointer [-Werror=array-parameter=]
    9 | int socketpair(int parm1, int parm2, int parm3, int * parm4)
      |                                                 ~~~~~~^~~~~
In file included from proxies/PROXY_socketpair.c:4:
/github/workspace/sources/nuttx/include/sys/socket.h:373:56: note: previously declared as an array 'int[2]'
  373 | int socketpair(int domain, int type, int protocol, int sv[2]);

@xiaoxiang781216 it seems like this issues started to appear after we switched to a new toolchain. Seems like CI is fully blocked now

Yes, it an expect result since the new version do more compiler check than before.
Here is fix: 32e4e70

@xiaoxiang781216

Copy link
Copy Markdown
Contributor Author

let's merge this simple pr directly to unblock the ci.

@xiaoxiang781216 xiaoxiang781216 merged commit ee82f7b into apache:master Oct 23, 2022
@xiaoxiang781216 xiaoxiang781216 deleted the error branch October 24, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants