Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER#7472
Merged
Conversation
xiaoxiang781216
force-pushed
the
nxmutex4
branch
2 times, most recently
from
c5132e2 to
e18a1f9
Compare
xiaoxiang781216
changed the title
xiaoxiang781216
force-pushed
the
nxmutex4
branch
4 times, most recently
from
bee9050 to
3085bb0
Compare
xiaoxiang781216
force-pushed
the
nxmutex4
branch
2 times, most recently
from
a9b1c09 to
c524607
Compare
masayuki2009
requested changes
Nov 1, 2022
Contributor
|
Hmm, it's too hard because the first commit is too big and has several changes other than the global mutex/sem initialization. |
xiaoxiang781216
force-pushed
the
nxmutex4
branch
2 times, most recently
from
83f2c0d to
fc65168
Compare
Contributor
Author
|
@masayuki2009 please review again, the change separate to small patch now. |
xiaoxiang781216
force-pushed
the
nxmutex4
branch
from
fc65168 to
a6dad33
Compare
pkarashchenko
left a comment
pkarashchenko
left a comment
Contributor
There was a problem hiding this comment.
100 files reviewed
Contributor
|
@gustavonihei could you please review ESP32 related files? |
gustavonihei
reviewed
Nov 3, 2022
xiaoxiang781216
force-pushed
the
nxmutex4
branch
4 times, most recently
from
4c20c1b to
bdb2c0c
Compare
masayuki2009
reviewed
Nov 8, 2022
Contributor
|
@xiaoxiang781216 |
xiaoxiang781216
force-pushed
the
nxmutex4
branch
from
bdb2c0c to
e523279
Compare
Contributor
Author
Done. |
xiaoxiang781216
force-pushed
the
nxmutex4
branch
3 times, most recently
from
9e4410c to
a0a002a
Compare
Contributor
Author
|
@masayuki2009 @pkarashchenko please review again. |
xiaoxiang781216
requested review from
gustavonihei,
masayuki2009 and
pkarashchenko
pkarashchenko
left a comment
pkarashchenko
left a comment
Contributor
There was a problem hiding this comment.
in general looks good. just few minor comments
Signed-off-by: anjiahao <anjiahao@xiaomi.com> Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: anjiahao <anjiahao@xiaomi.com> Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com> temp Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
and unlock the mutex before return Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
since both never fail Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
nxmutex4
branch
from
a0a002a to
b07802b
Compare
Contributor
Author
|
@masayuki2009 @pkarashchenko do you have more comment or merge it if no? |
Contributor
|
I do not have more comments. Let's wait one more day to get feedback from @masayuki2009 |
masayuki2009
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the work: #6965
Impact
Code refactor
Testing
Pass CI