Skip to content

Add ACT8945A power driver#8088

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
TimJTi:Add-ACT8945A-Regulator-Support
Jan 14, 2023
Merged

Add ACT8945A power driver#8088
xiaoxiang781216 merged 1 commit into
apache:masterfrom
TimJTi:Add-ACT8945A-Regulator-Support

Conversation

@TimJTi

@TimJTi TimJTi commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Summary

Adds device driver for Qorvo ACT8945A regulator. No battery charger or interrupt support at this time.

Created as a draft because:

  1. This is possibly the first NuttX driver using the power/consumer/regulator model - I had nothing to base it on
  2. I am unsure if the spin_lock calls (needed when an independent battery charge driver is written as it "shares" the same I2C interface to the device) are in the right place
  3. The usual feedback needing corrections is expected

Impact

None expected

Testing

On custom board using SAMA5D27C-D1M processor using this regulator.

@TimJTi TimJTi force-pushed the Add-ACT8945A-Regulator-Support branch from 7cdf17d to 66b1563 Compare January 11, 2023 20:23
Comment thread drivers/power/supply/act8945a.c
Comment thread drivers/power/supply/act8945a.c
Comment thread drivers/power/supply/act8945a.c Outdated
Comment thread drivers/power/supply/act8945a.c Outdated
Comment thread drivers/power/supply/act8945a.c Outdated
Comment thread drivers/power/supply/act8945a.c Outdated
Comment thread drivers/power/supply/act8945a.c Outdated
Comment thread drivers/power/supply/act8945a.c Outdated
Comment thread drivers/power/supply/act8945a.c
Comment thread drivers/power/supply/act8945a.c
@acassis

acassis commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Hi @TimJTi your drive seems in good shape, only simple/small fixes. After that you can remove the Draft flag

@TimJTi TimJTi force-pushed the Add-ACT8945A-Regulator-Support branch from 66b1563 to 976ebf6 Compare January 12, 2023 16:43
@TimJTi TimJTi marked this pull request as ready for review January 12, 2023 16:46
Comment thread drivers/power/supply/regulator_gpio.c Outdated
Comment thread drivers/power/supply/regulator.c Outdated
Comment thread drivers/power/supply/regulator.c Outdated
Update act8945a.c

Update Kconfig

Update act8945a.c

Corrections (xiaoxiang781216)
@TimJTi TimJTi force-pushed the Add-ACT8945A-Regulator-Support branch from 976ebf6 to 732fc1b Compare January 13, 2023 14:28
@xiaoxiang781216 xiaoxiang781216 merged commit f5e8c30 into apache:master Jan 14, 2023
@TimJTi TimJTi deleted the Add-ACT8945A-Regulator-Support branch January 14, 2023 14:56
Comment thread drivers/power/supply/act8945a.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants