Skip to content

signal/sig_dispatch: Revert changes that cause a regression#8763

Merged
jerpelea merged 2 commits into
apache:masterfrom
tiiuae:revert_sig_changes
Mar 8, 2023
Merged

signal/sig_dispatch: Revert changes that cause a regression#8763
jerpelea merged 2 commits into
apache:masterfrom
tiiuae:revert_sig_changes

Conversation

@pussuw

@pussuw pussuw commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Summary

This reverts changes that cause a regression in signal handling, more info in #8740

The problem still remains where signal actions are not performed / the user signal handler is not called if:

  • The signal recipient is in syscall
  • The signal recipient is waiting for a signal, i.e. stcb->task_state == TSTATE_WAIT_SIG

Only the process wake up part works, but the signal action is never performed. I need more time to fix this.

Impact

Fix regression

Testing

CI, code goes back to something that passes https://github.com/linux-test-project/ltp/blob/master/testcases/open_posix_testsuite/conformance/interfaces/timer_settime/9-2.c

@pussuw

pussuw commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

@xiaoxiang781216 I suggest we do the revert so I can take my time fixing the system call related issues

@jerpelea jerpelea merged commit 47ce89f into apache:master Mar 8, 2023
@pussuw pussuw deleted the revert_sig_changes branch March 8, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants