Skip to content

cmake: update docker cmake to 3.26.0#9865

Merged
xiaoxiang781216 merged 1 commit into
apache:masterfrom
raiden00pl:cmake_new
Jul 24, 2023
Merged

cmake: update docker cmake to 3.26.0#9865
xiaoxiang781216 merged 1 commit into
apache:masterfrom
raiden00pl:cmake_new

Conversation

@raiden00pl

@raiden00pl raiden00pl commented Jul 21, 2023

Copy link
Copy Markdown
Member

Summary

an attempt to fix broken FetchContent_Declare()
follow up to #9854

Impact

Testing

CI

@raiden00pl raiden00pl force-pushed the cmake_new branch 2 times, most recently from 7c446ac to 2db45b4 Compare July 21, 2023 08:06
@acassis

acassis commented Jul 23, 2023

Copy link
Copy Markdown
Contributor

@xiaoxiang781216 is it possible to create an image already with cmake-format to avoid the pip error? (error #11 https://acassis.wordpress.com/2023/06/20/nuttx-ci-github-failures-list/ )

@xiaoxiang781216

Copy link
Copy Markdown
Contributor

@xiaoxiang781216 is it possible to create an image already with cmake-format to avoid the pip error? (error #11 https://acassis.wordpress.com/2023/06/20/nuttx-ci-github-failures-list/ )

It's possible if we create a dedicated docker image or reuse the one we used to build nuttx image.

@anchao

anchao commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

@xiaoxiang781216 is it possible to create an image already with cmake-format to avoid the pip error? (error #11 https://acassis.wordpress.com/2023/06/20/nuttx-ci-github-failures-list/ )

Hi @raiden00pl @acassis
The cmake-format error has been resolved by PR #9864 , please rebase your code base and try again

@raiden00pl raiden00pl force-pushed the cmake_new branch 7 times, most recently from 50c6685 to bad03e3 Compare July 24, 2023 08:58
@raiden00pl

Copy link
Copy Markdown
Member Author

I'm opening this PR.
Nordic configurations that use FetchContent_Declare() passed CI.
This PR must be merged first before updating testlist files - the Docker image must be rebuild.

@raiden00pl raiden00pl marked this pull request as ready for review July 24, 2023 10:38
@xiaoxiang781216 xiaoxiang781216 merged commit 44b5eb3 into apache:master Jul 24, 2023
@raiden00pl raiden00pl deleted the cmake_new branch July 25, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants