Add support for Swift 5.4#140
Conversation
Luke-Roy-IBM
force-pushed
the
swift-5.4
branch
3 times, most recently
from
77c7e98 to
e8426cc
Compare
dgrove-oss
left a comment
dgrove-oss
left a comment
There was a problem hiding this comment.
One nitpick comment; otherwise lgtm. Thanks @Luke-Roy-IBM !
|
@Luke-Roy-IBM - I took a quick look and didn't see your name listed as having filed a CLA; please correct me if I missed it. If you haven't done a CLA yet, please follow the instructions at https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md. |
|
@dgrove-oss Thank you for making me aware of the CLA I will get right on it. |
Luke-Roy-IBM
force-pushed
the
swift-5.4
branch
4 times, most recently
from
31afd09 to
ce48cd1
Compare
- Added suport for Swift 5.4 by copying and adapting core of Swift 5.3. Files Modified during this Process (version set to 5.4 from 5.3): -- core/swift54Action/build.gradle -- core/swift54Action/CHANGELOG.md -- core/swift54Action/Dockerfile - Added Swift 5.4 entries to: -- settings.gradle -- .travis.yml -- README.md -- ansible/files/runtimes.json Add missing EOL add correct swift version to tests/dat/build.sh add correct swift version to settings.gradle Swift 5.3 runtime default set to false add akka fix
|
@Luke-Roy-IBM please rebase this on latest master to pick up the fixes from #139. Thanks |
|
Thanks for filing the CLA; I see Luke Roy listed in http://people.apache.org/unlistedclas.html now. As soon as we rebase and get a clean run from travis we can merge this. |
…-swift into swift-5.4
|
@dgrove-oss Thanks for the notice I have rebased my branch. |
|
We're missing in this PR the scala tests for the 5.4 runtime. |
Add missing Scala Tests for Swift 5.4 runtime fror Pull Request apache#140
Add missing Scala Tests for Swift 5.4 runtime fror Pull Request apache#140
Add missing Scala Tests for Swift 5.4 runtime fror Pull Request #140
4 participants
Added suport for Swift 5.4 by copying and adapting core of Swift 5.3.
Files Modified in the core during this Process (version set to 5.4 from 5.3):
Added Swift 5.4 entries to: