ORC-1555: Simplify fedora37 docker image#1694
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
Conversation
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request?
This PR aims to simplify `fedora37` docker image for Apache ORC 2.0.
- Explicitly install Java 17
- Remove unused Java8 and Java 11 installation
- Remove unused Maven installation.
### Why are the changes needed?
The docker image is outdated.
- Java 8 and 11-related branches are not used at all.
- The installed Java 17 was due to the transitive dependency of `maven` installation.
- The installed `Maven` is not used because we use `mvnw`.
### How was this patch tested?
Manual tests.
```
$ ./run-one.sh local main fedora37
...
Test project /root/build
Start 1: orc-test
1/8 Test #1: orc-test ......................... Passed 5.54 sec
Start 2: java-test
2/8 Test #2: java-test ........................ Passed 118.00 sec
Start 3: java-tools-test
3/8 Test #3: java-tools-test .................. Passed 0.09 sec
Start 4: java-bench-gen-test
4/8 Test #4: java-bench-gen-test .............. Passed 0.83 sec
Start 5: java-bench-scan-test
5/8 Test #5: java-bench-scan-test ............. Passed 0.74 sec
Start 6: java-bench-hive-test
6/8 Test #6: java-bench-hive-test ............. Passed 11.28 sec
Start 7: java-bench-spark-test
7/8 Test #7: java-bench-spark-test ............ Passed 3.49 sec
Start 8: tool-test
8/8 Test #8: tool-test ........................ Passed 7.92 sec
100% tests passed, 0 tests failed out of 8
Total Test time (real) = 147.89 sec
Built target test-out
Finished fedora37 at Sat Dec 23 19:32:19 PST 2023
```
Closes apache#1694 from dongjoon-hyun/ORC-1555.
Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to simplify
fedora37docker image for Apache ORC 2.0.Why are the changes needed?
The docker image is outdated.
maveninstallation.Mavenis not used because we usemvnw.How was this patch tested?
Manual tests.