Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion converters/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ Given the [TPC-DS example](../examples/tpcds_semantic_model.yaml) included in th

To add support for a new vendor:

1. Add the vendor to the `vendors` enum in the [core specification](../core-spec/spec.md) if not already present.
1. Use a stable `vendor_name` string in each custom extension emitted by the converter.
2. Define the custom extension schema for the vendor (what vendor-specific metadata fields are supported in the `data` JSON).
3. Implement the export converter (Ossie → Vendor).
4. Implement the import converter (Vendor → Ossie).
Expand Down
4 changes: 2 additions & 2 deletions python/src/ossie/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class OSIDialect(str, Enum):


class OSIVendor(str, Enum):
"""Vendors with supported custom extensions."""
"""Well-known vendor names for custom extensions."""

COMMON = "COMMON"
SNOWFLAKE = "SNOWFLAKE"
Expand Down Expand Up @@ -63,7 +63,7 @@ class OSICustomExtension(BaseModel):

model_config = ConfigDict(frozen=True)

vendor_name: OSIVendor
vendor_name: str
data: str


Expand Down