fix(dbt): resolve SUM_BOOLEAN semantic model for qualified columns - #292
Merged
QMalcolm merged 2 commits intoJul 31, 2026
Merged
Conversation
jbonofre
approved these changes
Jul 30, 2026
Member
|
@QMalcolm wdyt? |
QMalcolm
approved these changes
Jul 31, 2026
QMalcolm
left a comment
QMalcolm
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀 Thank you @fanruan-tuco for putting this together
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dataset resolution for
SUM_BOOLEANmetrics that reference qualified columns. The converter now reads the dataset qualifier from the parsed SQL expression instead of splitting the renderedCASEexpression.Related Issues
Fixes #265
Testing
cd converters/dbt uv run pytestResult: 99 passed.
Checklist
Converters
Tests
Compliance