First version of the OSI spec

[khush-bhatia]

First version of the OSI spec. It covers the following:

• Core semantic model structure
• Support for datasets, relationships, fields, and metrics
• Multi-dialect metric expressions
• Vendor extensibility framework
• Context for agents

[hahmadi]

Shouldn't this be an array of array of column names?

[khush-bhatia]

It is. The first array is indicated by the -. I know yaml is confusing that way.

[hahmadi]

I understand. But the comment on line 80 as well as examples in the comment block need an update to clarify this.

[hahmadi]

Can you add an example with two unique keys, each being composite?

[tlento]

I didn't get space to read through this prior to merge but my one main comment is this spec is under-specified.

For now it's not a big deal but there are a lot of opaque string and functionally untyped array types in here, which puts an enormous burden on all developers of converters to enumerate the possibilities of what those might contain.

We will need to go through and refine these before the spec is ready for publication or even for vendors to start building against it. If we are still going to use something like protobuf we'll need to resolve a lot of these issues in order to make that work well anyway, so I think that might be a good next step.

[khush-bhatia]

I didn't get space to read through this prior to merge but my one main comment is this spec is under-specified.

For now it's not a big deal but there are a lot of opaque string and functionally untyped array types in here, which puts an enormous burden on all developers of converters to enumerate the possibilities of what those might contain.

We will need to go through and refine these before the spec is ready for publication or even for vendors to start building against it. If we are still going to use something like protobuf we'll need to resolve a lot of these issues in order to make that work well anyway, so I think that might be a good next step.

I missed this comment before. Synced offline with Tom. This spec is a starting point, we will gradually move to a more typed spec as it evolves and yes we can maintain the spec in both proto and yaml format .