Skip to content

Change vendor_name from enum to free-form string #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khush-bhatia merged 3 commits into from
May 21, 2026
Merged

Change vendor_name from enum to free-form string #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e984cb
Change vendor_name from enum to free-form string
jochenchrist Mar 21, 2026
5d47c63
Fix remaining enum references for vendor_name
jochenchrist Mar 23, 2026
b1f67b5
Improve vendors array description in osi-schema.json
jochenchrist Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core-spec/osi-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"vendors": {
"type": "array",
"description": "Supported vendors for custom extensions (enumeration definition)",
"description": "List of vendor names used in custom extensions within this model",
"items": {
"$ref": "#/$defs/Vendor"
}
Expand All @@ -42,8 +42,8 @@
},
"Vendor": {
"type": "string",
"enum": ["COMMON", "SNOWFLAKE", "SALESFORCE", "DBT", "DATABRICKS", "GOODDATA"],
"description": "Supported vendors for custom extensions"
"examples": ["COMMON", "SNOWFLAKE", "SALESFORCE", "DBT", "DATABRICKS", "GOODDATA"],
"description": "Vendor name for custom extensions. Any string value is accepted."
},
"AIContext": {
"description": "Additional context for AI tools",
Expand Down
7 changes: 5 additions & 2 deletions core-spec/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ Supported SQL and expression language dialects for metrics and field definitions

### Vendors

Supported vendors for custom extensions and integrations.
The `vendor_name` field is a free-form string, allowing any vendor or organization to
define custom extensions without requiring changes to the core specification.

The following are well-known examples:

| Vendor | Description |
|--------|-------------|
Expand Down Expand Up @@ -360,7 +363,7 @@ Custom extensions allow vendors to add platform-specific metadata without breaki

```yaml
custom_extensions:
- vendor_name: string # Must be from vendors enum
- vendor_name: string # Free-form string identifying the vendor
data: string # JSON string containing vendor-specific data
```

Expand Down
11 changes: 3 additions & 8 deletions core-spec/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,9 @@ dialects:



# Supported vendors for custom extensions
vendors:
- "COMMON"
- "SNOWFLAKE"
- "SALESFORCE"
- "DBT"
- "DATABRICKS"
- "GOODDATA"
# Vendor name for custom extensions (free-form string)
# Examples: "COMMON", "SNOWFLAKE", "SALESFORCE", "DBT", "DATABRICKS", "GOODDATA"
vendor_name: string


# Top-level semantic model definition
Expand Down