Use independent parameters for Otava algorithms#6
Merged
Conversation
In apache/otava#154, Henrik mentioned that using the same P-value for all 3 algorithms is not a fair comparison. > The deterministic variant finds much less change points for the > same p-values. It is closer to original edivisive in behavior than to > the hunter variant. To some extent this is a matter of perspective too: Who's to say we should compare them with constant p-values This patch allows setting P-values independently for all 3 algorithms. It also "boxes" window size to the split algorithm, which may be a more intuitive UX for new users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In apache/otava#154, @henrikingo mentioned that using the same P-value for all 3 algorithms is not a fair comparison.
This patch allows setting P-values independently for all 3 algorithms. It also "boxes" window size to the split algorithm, which may be a more intuitive UX for new users.