HDDS-14945. Implement Iceberg position delete file rewrite for path migration#10306
Open
sreejasahithi wants to merge 3 commits into
Open
HDDS-14945. Implement Iceberg position delete file rewrite for path migration#10306sreejasahithi wants to merge 3 commits into
sreejasahithi wants to merge 3 commits into
Conversation
Contributor
Author
|
@ashishkumar50 could you please review this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Position delete files of an Iceberg table contain the absolute path to the data files which contains the rows deleted.
We need to rewrite these position delete files as part of path migration. For each selected position delete file, we can take help of Iceberg's RewriteTablePathUtil to change sourcePrefix to targetPrefix for each data file absolute path mentioned in it, and add the rewritten position delete file to a staging location.
Introduce OzonePositionDeleteReaderWriter, which implements Iceberg’s PositionDeleteReaderWriter, to perform format-specific reads and writes for Avro, Parquet, and ORC.
Also added test coverage wrt position delete files and manifest file.
What is the link to the Apache JIRA
HDDS-14945
How was this patch tested?
Updated testcases
Green CI : https://github.com/sreejasahithi/ozone/actions/runs/26036208134