HDDS-15304. DeleteObjects should enforce the request key limit#10309
Open
sreejasahithi wants to merge 1 commit into
Open
HDDS-15304. DeleteObjects should enforce the request key limit#10309sreejasahithi wants to merge 1 commit into
sreejasahithi wants to merge 1 commit into
Conversation
Contributor
Author
|
@peterxcli could you please review this patch. |
peterxcli
approved these changes
May 19, 2026
Contributor
Author
|
Sample output after the fix. |
peterxcli
reviewed
May 19, 2026
|
|
||
| if (request.getObjects() != null | ||
| && request.getObjects().size() > S3Consts.S3_DELETE_OBJECTS_MAX_KEYS) { | ||
| throw newError(S3ErrorTable.MALFORMED_XML, bucketName); |
Member
There was a problem hiding this comment.
I think we should throw clear exception
Suggested change
| throw newError(S3ErrorTable.MALFORMED_XML, bucketName); | |
| throw newError(S3ErrorTable.INVALID_ARGUMENT, "too many objects"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The multi object delete iterates all request entries and forwards them to bucket.deleteKeys without checking the S3 1000 key maximum limit.
It should reject DeleteObjects requests with more than 1000 objects before execution and return the error.
What is the link to the Apache JIRA
HDDS-15304
How was this patch tested?
Added testcases
Green CI : https://github.com/sreejasahithi/ozone/actions/runs/26077522597