HDDS-15288. Use SequenceIdType in StateManagerImpl.#10313
Open
navinko wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi @szetszwo , added the changes. Once you get some time please review it . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Used SequenceIdType for sequenceIdToLastIdMap in StateManagerImpl
Please describe your PR in detail:
Refactored sequenceIdToLastIdMap in StateManagerImpl from <String, Long> to <SequenceIdType, Long>.
Updated allocateBatch(), getLastId(), and initialize() to safely convert DB key of string type to SequenceIdType Enums using SequenceIdType.valueOf().
Also as per the Jira, the @replicate method signatures were NOT changed to maintain RPC compatibility.
Regarding the change related to other in-memory data structure -sequenceIdTable, will create a separate PR with SequenceIdType codec by moving away from default StringCodec to support serialization and adapt SequenceIdType
for Table<String, Long> --> Table<SequenceIdType, Long>
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15288
How was this patch tested?
Added new test cases under TestSequenceIDGenerator and validated changes.
Ran locally, docker-compose and validated the flow for reinitialise with scm failover
Successful CI build:
https://github.com/navinko/ozone/actions/runs/26101162654