HDDS-12715. Add integration tests for debug-replicas-verify-checksums tool

[ptlrs]

Please describe your PR in detail:

• This PR hooks into the NonHATests framework to obtain a shared MiniOzoneCluster that can be used by other CLI tests
• It adds integration tests for the ozone debug replicas verify checksums command

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12715

How was this patch tested?

CI: https://github.com/ptlrs/ozone/actions/runs/16375920556

[adoroszlai]

Thanks @ptlrs for working on this.

Moving cluster creation to an extension reduces duplication, but:

• test execution is still unnecessarily long, because each test class needs to start its own cluster
• the specific implementation does not allow config to be customized if needed

Please check TestOzoneIntegrationNonHA and its parent classes for a better way to reuse a shared cluster for multiple test classes (HDDS-12183 and several later sub-tasks of HDDS-9000).

[ptlrs]

Thanks for the review @adoroszlai.
I agree, the cluster config here is limited to what is set in the extension.

With the custom extension, the cluster is created only once for both the test classes. The cluster is initialized once and stored as a static member. I had confirmed this by logging the creation of MiniOzoneCluster.

Is the goal of the new approach to consolidate all tests that can reuse the same config/cluster?

[ptlrs]

Hi @adoroszlai, the PR has been updated to use the existing TestOzoneIntegrationNonHA class. Could you please take another look.

[adoroszlai]

Thanks @ptlrs for updating the patch.

I think the PR title also needs to be updated.

[ptlrs]

Hi @adoroszlai @dombizita, could you please review this updated PR when you get a chance? Thanks.

[adoroszlai]

Thanks @ptlrs for updating the patch.

[ptlrs]

Hi @adoroszlai, the test has been updated. Could you please take another look.

patch updated

[dombizita]

Thanks for updating your patch @ptlrs, it looks good to me! Please update the jira title, so it'll match with the actual implementation. One more thing, there is also a --block-existence and --container-state flag for the ozone debug replicas verify tool, we have acceptance tests for it, do you think it'd a good idea to add tests for those in this patch? I know this PR is pending for a while, so I'm fine with this state as well.

[ptlrs]

Thanks for the review @dombizita. Let's open a new task for adding the tests for the block-existance and container-state features. This PR is in continuation of the work that was done for the checksums tool. I am not familiar with the other two features, so a new task to handle it spearately would be better.

[dombizita]

@ptlrs sounds good to me, thanks! Could you please merge latest master to this branch? It's been a month since the last time, once that's done I'll start CI and if all looks good we can merge!

[sarvekshayr]

Thanks for working on this @ptlrs.

Tests for the remaining verification flags can either be added in a follow-up JIRA or skipped since we already have acceptance tests covering them.

Overall, this LGTM.

[Tejaskriya]

Thanks for working on this @ptlrs , LGTM

[Tejaskriya]

Thanks for the reviews @dombizita @sarvekshayr @adoroszlai , and the contribution @ptlrs