Skip to content

[hotfix] remove the useless comment #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Jan 13, 2025
Merged

[hotfix] remove the useless comment #4889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...on-spark-ut/src/test/scala/org/apache/paimon/spark/sql/InsertOverwriteTableTestBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,6 @@ abstract class InsertOverwriteTableTestBase extends PaimonSparkTestBase {
sql(
"INSERT INTO t VALUES (1, STRUCT(1, 1)), (2, null), (3, STRUCT(1, null)), (4, STRUCT(null, null))")
if (format.equals("parquet")) {
// todo: fix it, see https://github.com/apache/paimon/issues/4785
Copy link
Copy Markdown
Contributor

@Zouxxyy Zouxxyy Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, This bug has not been fixed. Please read carefully: #4785.

Copy link
Copy Markdown
Contributor

@Zouxxyy Zouxxyy Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the fix, we do not need this if-else statement..

Copy link
Copy Markdown
Contributor Author

@yangjf2019 yangjf2019 Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review! Sorry for the inconvenience. Can we reopen it?

Copy link
Copy Markdown
Contributor

@Zouxxyy Zouxxyy Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it’s not necessary, we will start fixing it soon

checkAnswer(
sql("SELECT * FROM t ORDER BY i"),
Seq(Row(1, Row(1, 1)), Row(2, null), Row(3, Row(1, null)), Row(4, null)))
Expand Down