[Core]Introduce ResolvingFileIO#4891
Merged
Merged
Conversation
JingsongLi
reviewed
Jan 14, 2025
JingsongLi
reviewed
Jan 14, 2025
wwj6591812
reviewed
Jan 14, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
JingsongLi
reviewed
Jan 17, 2025
neuyilan
changed the title
JingsongLi
reviewed
Jan 21, 2025
JackeyLee007
pushed a commit
to JackeyLee007/paimon
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Due to the introduction of an external path[1], we are unable to use the warehouse's
FileIOto read and write files. So we introducedResolvingFileIO, which allows us to choose the appropriate fileio based on the prefix scheme of the path.This job is a part of this job[2]
[1] #4751
[2] https://cwiki.apache.org/confluence/display/PAIMON/PIP-29%3A+Introduce+Table+Multi-Location++Management
Tests
Add HybridFileIOTest.java UT
API and Format
no change
Documentation
Because the external path of the file is on the table options. So we don't know the specific file write path from the options in the catalog. So we don't know the underlying write path is an object store or not.
So we need to modify the
write-buffer-spillableparameter. Make it default to false