[flink] FlinkCatalog#listTables returns both tables and views#5910
Conversation
|
Hi @yunfengzhou-hub, can you review this PR? |
|
Hi @Sxnan Thanks for the PR. It might be better to also check if other APIs have similar syntax gap and fix them altogether. Besides, could you add some tests to verify the correctness of this change? |
6e8c0b5 to
e0773e8
Compare
|
@yunfengzhou-hub I checked the other APIs and only |
It seems that FlinkCatalog#alterTable does not support alter Views yet. But different from listTables, this method could explicitly throw exception instead of returning a wrong response, so the support would be more adding a new feature than fixing a bug. Thus we can consider add such supports in future PRs. |
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM.
Purpose
Linked issue: close #5781
According to Flink's Catalog#listTables method's Javadoc, the
FlinkCatalog#listTablesmethod should return all tables and views under a certain database.Tests
API and Format
Documentation