[filesystems]Support Tencent COSN (#842)#843
Closed
daixiaoyu wants to merge 1 commit into
Closed
Conversation
Member
|
@daixiaoyu, could you add the test cases for loader of Tencent COSN support? |
Contributor
Author
|
@SteNicholas Okay, I'll try. |
SteNicholas
reviewed
Apr 6, 2023
| private static synchronized PluginLoader getLoader() { | ||
| if (loader == null) { | ||
| // Avoid NoClassDefFoundError without cause by exception | ||
| loader = new PluginLoader(COSN_JAR); |
Member
There was a problem hiding this comment.
Why is COSN_JAR fixed? Is it necessary to make the name to the final paimon-plugin-cosn.jar? Other jar name could not?
Contributor
Author
There was a problem hiding this comment.
Here I refer to the implementation of OSS, mainly to the code style can be unified
JingsongLi
reviewed
Apr 7, 2023
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @daixiaoyu for the contribution. Left one comment.
Can you explain what is COSN? I only know COS.
I know there is S3 client for COS.
So what is difference between S3 client and COSN client?
Member
|
@daixiaoyu, any comments or updates for above review comments? |
Contributor
Author
|
This can be close , Tencent COS can use S3 FileSystem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[filesystems]
Purpose
Support Tencent COSN
Documentation
(Does this change introduce a new feature)
change paimon/docs/content/filesystems/overview.md
add paimon/docs/content/filesystems/cosn.md