This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-1177: Add PARQUET_BUILD_WARNING_LEVEL option and more rigorous Clang warnings#425
Closed
wesm wants to merge 9 commits into
Closed
PARQUET-1177: Add PARQUET_BUILD_WARNING_LEVEL option and more rigorous Clang warnings#425wesm wants to merge 9 commits into
wesm wants to merge 9 commits into
Conversation
…LEVEL flag. Fix Clang compiler warnings
xhochy
approved these changes
Dec 12, 2017
xhochy
left a comment
xhochy
left a comment
Member
There was a problem hiding this comment.
+1, go ahead on green build. Didn't notice that we had these in Arrow, this looks really helpful.
Member
Author
|
Think I've got the compiler warnings fixed now, we'll see about MSVC |
Member
Author
|
I have gcc 4.9 and clang 4.0 on my (also Ubuntu 14.04) machine but cannot reproduce these compiler warnings for some reason. Not sure what's wrong |
Member
Author
|
Appveyor build in progress on my fork https://ci.appveyor.com/project/wesm/parquet-cpp/build/1.0.181. Will merge once the build is green |
Member
Author
|
Travis CI passing https://travis-ci.org/wesm/parquet-cpp/builds/316090912. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These warnings will catch a number of things that have bitten us in the past, like missing virtual destructors. This brings Parquet's compiler warnings up to the same quality as Arrow's