Add parameterized forward index compression codecs#18188
Open
xiangfu0 wants to merge 1 commit intoapache:masterfrom
Open
Add parameterized forward index compression codecs#18188xiangfu0 wants to merge 1 commit intoapache:masterfrom
xiangfu0 wants to merge 1 commit intoapache:masterfrom
Conversation
fd5672b to
1a5b303
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18188 +/- ##
============================================
+ Coverage 63.29% 63.40% +0.10%
- Complexity 1627 1646 +19
============================================
Files 3226 3230 +4
Lines 196636 196904 +268
Branches 30401 30447 +46
============================================
+ Hits 124466 124844 +378
+ Misses 62192 62042 -150
- Partials 9978 10018 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompressionCodecSpecparsing and validation so forward-index compression stays externally string-based while supporting optional integer parametersUser manual
Raw forward indexes can now set
fieldConfigList[].compressionCodecwith either a plain codec name or a codec plus integer level.Examples:
Existing values such as
SNAPPY,LZ4,PASS_THROUGH, and legacychunkCompressionType/dictIdCompressionTypeconfigs continue to work.Sample table config
{ "fieldConfigList": [ { "name": "column1", "encodingType": "RAW", "compressionCodec": "ZSTD(3)" } ] }Testing
./mvnw spotless:apply -q./mvnw license:format -q./mvnw -pl pinot-segment-local,pinot-segment-spi,pinot-spi,pinot-tools -am -DskipTests compile -q./mvnw -pl pinot-segment-local,pinot-segment-spi,pinot-spi,pinot-common -am -Dtest=ForwardIndexConfigTest,CompressionCodecSpecTest,CompressionCodecSpecValidatorTest,TableConfigSerDeUtilsTest,ForwardIndexCreatorFactoryTest,BaseSegmentCreatorTest,ForwardIndexTypeTest,IndexLoadingConfigTest,ForwardIndexHandlerTest,TestCompression -Dsurefire.failIfNoSpecifiedTests=false test -q./mvnw checkstyle:check -q./mvnw license:check -q