Skip to content

[Issue 342][consumer] add key shared policy support - #363

Merged
wolfstudy merged 2 commits into
apache:masterfrom
syklevin:master
Oct 9, 2020
Merged

[Issue 342][consumer] add key shared policy support#363
wolfstudy merged 2 commits into
apache:masterfrom
syklevin:master

Conversation

@syklevin

@syklevin syklevin commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

Fixes #342

Motivation

Add support for KeySharedPolicy with AutoSplit or Sticky mode for consumer, which is a useful for some user cases like scalable request-reply pattern.

Modifications

add key shared policy options for consumer, and a helpful constructor for validating hash range list

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@wolfstudy wolfstudy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, Thanks @syklevin work for this, the change LGTM +1

@wolfstudy

Copy link
Copy Markdown
Member

@codelipenghui Can you help review this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyShared with sticky hash range support

3 participants