Skip to content

[Issue #401] Add orderingKey apis - #427

Merged
wolfstudy merged 4 commits into
apache:masterfrom
freeznet:add-orderingKey-apis
Dec 23, 2020
Merged

[Issue #401] Add orderingKey apis#427
wolfstudy merged 4 commits into
apache:masterfrom
freeznet:add-orderingKey-apis

Conversation

@freeznet

Copy link
Copy Markdown
Contributor

Fixes #401

Motivation

According to apache/pulsar#4079, orderingKey was introduced to let user set message order manually, currently pulsar-client-go do not have related apis exposed to user. We should add orderingKey related apis to pulsar-client-go.

Modifications

  • add OrderingKey to ProducerMessage
  • add OrderingKey() to Message interface
  • sync OrderingKey to SingleMessageMetadata
  • tests

@freeznet freeznet changed the title [Issue #401] Add ordering key apis [Issue #401] Add orderingKey apis Dec 22, 2020
@freeznet

Copy link
Copy Markdown
Contributor Author

@wolfstudy would you please help to review this pr, thanks.

@wolfstudy wolfstudy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy added this to the 0.4.0 milestone Dec 23, 2020
@wolfstudy
wolfstudy merged commit 9b20cc0 into apache:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add OrderingKey related apis

2 participants