Skip to content

feat: add basic authentication - #778

Merged
merlimat merged 1 commit into
apache:masterfrom
nodece:basic_auth
Jun 23, 2022
Merged

feat: add basic authentication#778
merlimat merged 1 commit into
apache:masterfrom
nodece:basic_auth

Conversation

@nodece

@nodece nodece commented May 25, 2022

Copy link
Copy Markdown
Member

Motivation

Miss the basic authentication.

Modifications

  • Add the basic authentication provider in internal/auth
  • Add factory method of basic authentication provider in client.go
  • Configure the basic authentication provider in integration tests

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@nodece nodece closed this May 26, 2022
@nodece nodece reopened this May 26, 2022

@liangyuanpeng liangyuanpeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants