Add C++ 3.x releases into download page - #300
Merged
Merged
Conversation
BewareMyPower
requested review from
Anonymitaet,
merlimat,
tisonkun and
urfreespace
November 23, 2022 05:10
tisonkun
reviewed
Nov 23, 2022
tisonkun
reviewed
Nov 23, 2022
merlimat
approved these changes
Nov 23, 2022
tisonkun
approved these changes
Nov 23, 2022
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
Good to go.
Potential follow-ups:
- Common lib to provide release info (and resolved to current version);
- Add download links to DEB and RPM installer;
- Update links in the C++ client library doc page.
Contributor
Author
It might be a little hard. We have multiple packages now (DEB, RPM, APK for both x64 and arm64), add there will be releases for Windows or macOS in future. It's better to provide a guide and encourage users to download the proper packages.
I'm working on it at the moment and will open a PR soon. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ client version has been no longer consistent with the Pulsar version since Pulsar 2.11.0. We need to provide the download URLs for packages of new 3.x releases.