[fix] ready-to-test is not applicible for docs only changes - #328
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
tisonkun
commented
Dec 13, 2022
| ## ready-to-test | ||
|
|
||
| After [PR-17693](https://github.com/apache/pulsar/pull/17693) merged, pull requests should be first tested in your own fork since the pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. | ||
| After [PR-17693](https://github.com/apache/pulsar/pull/17693) merged, pull requests **except [docs only changes](https://github.com/apache/pulsar/blob/master/.github/changes-filter.yaml#L5)** should be first tested in your own fork since the pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. |
Member
Author
There was a problem hiding this comment.
The contribution guide should be always up-to-date, so I hold a link to the master branch. If the master branch changes, we should update the corresponding line links.
Member
Author
|
Merging... If the wording can be improved further, welcome to leave a comment or send another patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from apache/pulsar#18878 (comment).
This closes #327.