[improve][doc] Add doc for pulsar.enableUring property - #428
Merged
Conversation
coderzc
force-pushed
the
zhaocong/io_uring_doc
branch
from
February 20, 2023 07:30
5df8812 to
09021c2
Compare
momo-jun
reviewed
Feb 20, 2023
momo-jun
reviewed
Feb 20, 2023
momo-jun
reviewed
Feb 20, 2023
Contributor
|
@coderzc thanks for adding the docs. I left a couple of suggestions. Can you pls invite a peer to review this PR from a tech perspective? |
tisonkun
approved these changes
Feb 21, 2023
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
+1 it's technically right
... while I may wondering that references is not counted in the search index.
Member
|
Merging... Further improvement may be made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: apache/pulsar#18385
Documentation
docdoc-requireddoc-not-neededdoc-complete