[Issue-9889] [integration tests] Refactored Function integration tests - #10140
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
|
Add description for changes. |
aahmed-se
approved these changes
Apr 9, 2021
Contributor
|
@david-streamlio can you fix the conflicts please? |
Member
|
@freeznet Can you review this pull request? |
david-streamlio
force-pushed
the
Issue-9889
branch
from
May 5, 2021 23:39
47aabbc to
4d872cb
Compare
Contributor
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
freeznet
approved these changes
May 7, 2021
jerrypeng
approved these changes
May 11, 2021
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
May 11, 2021
apache#10140) Co-authored-by: David Kjerrumgaard <dkjerrumgaard@splunk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9889
Motivation
Restructure the function integration tests for easier maintainability going forward
Modifications
I have broken out the existing test cases into separate classes based upon the type of Function we are trying to test, e.g Go, Java, Python, etc. Previously all of these tests were in a single class which violates OOP principles significantly
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation