[Issue 10161] Fix missing LoggerFactoryPtr type. - #10164
Conversation
|
@merlimat You wan't to base this on master? |
|
@astifter Yes, the PR should be targeting master. Once it's merged then it will be cherry picked for on the 2.7 branch |
|
@astifter can you send a PR for master branch ? |
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I am commenting with "Request changes" in order to clarify the status of this patch
|
Sorry, missed the deadline for 2.7.2, but I have rebased the change on master. |
|
@astifter thanks for your code work. For this PR, do we need to update docs? |
No, this just fixes the compile. |
|
LGTM. This bug was not exposed because CI only build cpp client with |
|
I misunderstood, the name of the branch on your repo is "branch-2.7" but the target branch is "master" |
Yes, sorry about that. I was working of the 2.7 branch and didn't pay attention. I couldn't change the branch easily so I kept the name. Promise to be more careful in the future. |
Fixes apache#10161. ### Motivation With issue apache#7132 the LoggerFactoryPtr was removed in favour of relevant memory-safe(r) pointers. This change forgot to also change the Log4Cxx implementation, fix this by returning (as with the other LoggerFactory's) a std::unique_ptr<LoggerFactory>.
Fixes #10161. ### Motivation With issue #7132 the LoggerFactoryPtr was removed in favour of relevant memory-safe(r) pointers. This change forgot to also change the Log4Cxx implementation, fix this by returning (as with the other LoggerFactory's) a std::unique_ptr<LoggerFactory>. (cherry picked from commit d700f8d)
Fixes apache#10161. ### Motivation With issue apache#7132 the LoggerFactoryPtr was removed in favour of relevant memory-safe(r) pointers. This change forgot to also change the Log4Cxx implementation, fix this by returning (as with the other LoggerFactory's) a std::unique_ptr<LoggerFactory>.
7 participants
Fixes #10161.
Motivation
With issue #7132 the LoggerFactoryPtr was removed in favour of relevant memory-safe(r) pointers.
This change forgot to also change the Log4Cxx implementation, fix this by returning (as with
the other LoggerFactory's) a std::unique_ptr.
Modifications
Change remaining LoggerFactoryPtr in Log4Cxx factory to std::unique_ptr to conform to #7132.
Verifying this change