[Tests] Add TestNG listeners for resource cleanup, thread leak detection and "fail fast"#10195
Merged
eolivelli merged 1 commit intoApr 13, 2021
Conversation
- add listeners for cleaning up
- Mockito mocking state in all threads
- FastThreadLocal state with org.apache.pulsar.* class instances
in all threads
- add listener for detecting leaked threads
- rewrite RetryAnalyzer based on TestNG's RetryAnalyzerCount class
- add tests for RetryAnalyzer
- Fix test dependencies in pulsar-io/flume and pulsar-io/netty
- add custom fail fast solution
- Maven Surefire built-in solution is broken with TestNG 7.3.0
Member
Author
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Apr 13, 2021
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
LGTM
@codelipenghui @congbobo184 PTAL
CI passed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There are a lot of resource cleanup issues in Pulsar tests. This PR adds some TestNG listeners to mitigate the problem.
Modifications
add TestNG listeners for cleaning up
org.apache.pulsar.*class instances in all threadsadd TestNG listener for detecting leaked threads
rewrite RetryAnalyzer based on TestNG's RetryAnalyzerCount class
Fix test dependencies in pulsar-io/flume and pulsar-io/netty
add custom fail fast solution