[Issue 10046] Update chuckedMessageRate to chunkedMessageRate without breaking public api - #10223
Merged
codelipenghui merged 1 commit intoApr 15, 2021
Conversation
merlimat
approved these changes
Apr 14, 2021
michaeljmarshall
force-pushed
the
fix-chuck-to-chunk-typo
branch
from
April 15, 2021 06:25
7ba748e to
bae81ef
Compare
Member
Author
|
Needed to rebase to resolve conflicts. Only updated the |
codelipenghui
approved these changes
Apr 15, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2021
…ngChunkedMessage (#10253) In #10223, I fixed many references to `chuck` that should have been `chunk`. I missed one documentation reference. This PR fixes that. (Note that the old 2.6.x and 2.7.x documentation still reference `chuck` because that is what the java client's API uses. Moving forward, we will use `chunk`, as #10223 demonstrates.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10046
Motivation
As described in #10046, there is a typo where
chuckis used instead ofchunkin several locations, including in the public API. This PR fixes that typo without introducing any breaking changes. Instead, it adds some new methods while deprecating ones that contain typos.Modifications
ConsumerBuilderinterface by first deprecating themaxPendingChuckedMessagemethod and adding themaxPendingChunkedMessagemethod. We'll need to choose when to actually remove the deprecated method.SubscriptionStatsto return bothchuckedMessageRateandchunkedMessageRate. Given that this POJO is sent as JSON, the only way to give users the chance to transition is to deliver both fields.ConsumerStatsto return bothchuckedMessageRateandchunkedMessageRate. Given that this POJO is sent as JSON, the only way to give users the chance to transition is to deliver both fields.ConsumerConfigurationDataby changing the private variable frommaxPendingChuckedMessagetomaxPendingChunkedMessage. Then, add the previously generated getter and setter formaxPendingChuckedMessagethat actually updatemaxPendingChunkedMessage.Verifying this change
I updated several tests but didn't add any. I'm not sure what the protocol is for these types of changes. The public API is not changing, and in the case of deprecated methods, any affected tests are updated to use the new methods.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesThe changes to the public API are only additive.
Documentation
There is updated documentation associated with this change. If we want to merge this change to the 2.7 branch, we'll want to update that documentation as well.